Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Go 1.9 support #1017

Merged
merged 2 commits into from
Dec 11, 2019
Merged

Drop Go 1.9 support #1017

merged 2 commits into from
Dec 11, 2019

Conversation

methane
Copy link
Member

@methane methane commented Oct 21, 2019 •
edited
Loading

Description

Legacy GAE/Go is gone.

README says "We aim to support the 3 latest versions of Go."
"the 3 latest versions of Go" are 1.13, 1.12, and 1.11.

But there is no enough reason to drop 1.10 support at the moment.
So we keep Go 1.10 support in v1.5.

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file

@methane methane closed this Nov 8, 2019
@methane methane reopened this Nov 8, 2019
@methane methane requested a review from julienschmidt November 8, 2019 12:13
@methane methane mentioned this pull request Nov 8, 2019
Merged
4 tasks
@methane methane requested a review from shogo82148 December 11, 2019 03:46
@methane
Copy link
Member Author

methane commented Dec 11, 2019

@shogo82148 Please merge this.

@methane methane mentioned this pull request Dec 11, 2019
Closed
@shogo82148 shogo82148 merged commit 94084c9 into go-sql-driver:master Dec 11, 2019
reireias added a commit to reireias/mysql that referenced this pull request Dec 12, 2019
@reireias
Revert "Drop Go 1.9 support (go-sql-driver#1017)"
17d1aad 
This reverts commit 94084c9.
@julienschmidt julienschmidt added this to the v1.5.0 milestone Jan 3, 2020
tz70s pushed a commit to tz70s/mysql that referenced this pull request Sep 5, 2020
@methane @tz70s
Drop Go 1.9 support (go-sql-driver#1017)
a1acc60 
* Drop Go 1.9 support

* Add test for Go 1.13.
tz70s pushed a commit to tz70s/mysql that referenced this pull request Sep 5, 2020
@methane @tz70s
Drop Go 1.9 support (go-sql-driver#1017)
521a799 
* Drop Go 1.9 support

* Add test for Go 1.13.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shogo82148 shogo82148 shogo82148 approved these changes

@julienschmidt julienschmidt Awaiting requested review from julienschmidt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@methane @shogo82148 @julienschmidt